-
Notifications
You must be signed in to change notification settings - Fork 72
4.x/Release Compile Workflow Update #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.x/Release Compile Workflow Update #345
Conversation
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the release and compile workflows for the XMC-for-Arduino project by transitioning to reusable workflows from arduino-devops and updating the package configuration. The proposed changes include adding a new package configuration, introducing a CI matrix file, updating GitHub workflows for release and compiling examples, and removing the obsolete release.py script.
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
package/config.yml | Added new package configuration for xmc-for-arduino |
ci-matrix-config.yml | Introduced CI matrix configuration with relevant examples and commented options |
.github/workflows/release.yml | Updated release workflow to use the shared arduino-devops workflow |
.github/workflows/compile-examples.yml | Added compile examples workflow using the shared workflow |
.github/scripts/release.py | Removed obsolete release script now replaced by the reusable workflow |
Files not reviewed (3)
- .github/workflows/compile-platform-examples.yml: Language not supported
- .gitmodules: Language not supported
- extras/arduino-examples: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
- Infineon:xmc:XMC4700_Relax_Kit | ||
|
||
# sketch: | ||
# - libraries/LED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an example for the LED class. I am not sure if it is needed.
Anyhow, all the commented examples and modules, which now need to be refactor can be also cleanup. We can remove any example that is no longer relevant or needed.
I just kept examples against the boards from the 3.x. Those are compiling in that version.
A small question, does the MacOS test here differentiate between x86 chips and arm architecture M-series chips? |
Discussed in the other channel :D |
I will merge, the yml file is a list written in stone, we will adapt it as we enabled modules. But with this we should start under to CI what is enabled, and keep it green. Let´s start with the UART. |
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Updating "release" and "compile-examples" workflows
based on reusable workflows from arduino-devops.
Failing as this Serial is present in pins_arduino.h, but not yet added.