Psoc6 ble board#168
Conversation
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
dineshgit411
force-pushed
the
psoc6-ble-board
branch
from
df819d2 to
eba1486
Compare
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
dineshgit411
requested review from
ederjc,
jaenrig-ifx and
ramya-subramanyam
as code owners
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
LinjingZhang
left a comment
LinjingZhang
left a comment
There was a problem hiding this comment.
Well done!
HiL has been passed, so I will just approve here.
There was a problem hiding this comment.
please check docs/run-tests.rst.
if the hil setup should be docummented
| #define TEST_ADC_RESOLUTION 11 | ||
| #define TEST_ADC_MAX_VALUE 2048 // 11-bit resolution | ||
| #elif defined(CY8CPROTO_063_BLE) | ||
| #define TEST_PIN_DIGITAL_IO_OUTPUT 17 // IO_4 |
There was a problem hiding this comment.
like you told me, the comments here are wrong.
maybe just simply remove it. These defines are self-explained
| cy8cproto_063_ble.build.board=CY8CPROTO_063_BLE | ||
| cy8cproto_063_ble.build.core=psoc6 | ||
| cy8cproto_063_ble.build.variant=CY8CPROTO-063-BLE | ||
| cy8cproto_063_ble.build.board.version=release-v4.2.0 |
There was a problem hiding this comment.
what is the build.board.version?
There was a problem hiding this comment.
I don´t think we are using this variable. But it is the board BSP asset repository version.
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
jaenrig-ifx
left a comment
jaenrig-ifx
left a comment
There was a problem hiding this comment.
All looking very good! 🦾
Only some minor fixes in the documentation, and I would like to clarify the pinout arduino mapping topic.
Well done! 👍
| .. image:: img/board_CY8CKIT-062S2-AI.png | ||
| :width: 300 | ||
|
|
||
| CY8CPROTO-063-BLE |
There was a problem hiding this comment.
This section should start below the CY8CKIT-062S2-AI section:
https://arduino-core-psoc6.readthedocs.io/en/psoc6-ble-board/hw-platforms.html#cy8ckit-062s2-ai
There was a problem hiding this comment.
I see that the arduino pin numbering is trying to follow a port pin allocation. Personally, I would expect that these arduino pin numbers are consecutive. Any reason or advantage to implement this mapping in this way?
| cy8cproto_063_ble.build.board=CY8CPROTO_063_BLE | ||
| cy8cproto_063_ble.build.core=psoc6 | ||
| cy8cproto_063_ble.build.variant=CY8CPROTO-063-BLE | ||
| cy8cproto_063_ble.build.board.version=release-v4.2.0 |
There was a problem hiding this comment.
I don´t think we are using this variable. But it is the board BSP asset repository version.
4 participants
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Updated library files mostly in this PR so you can skip it more files here.
Updated Pin_arduino, test config, boards.txt, platform.txt, HIL config files for BLE board.
https://github.com/Infineon/arduino-core-psoc6/actions/runs/24186313536 - HIL Checks passed