Improve uart gpio test #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinjingZhang
requested review from
jaenrig-ifx,
IFX-Anusha and
ramya-subramanyam
jaenrig-ifx
reviewed
Apr 11, 2025
Signed-off-by: zhanglinjing <[email protected]>
Signed-off-by: zhanglinjing <[email protected]>
Signed-off-by: zhanglinjing <[email protected]>
LinjingZhang
force-pushed
the
improve-uart-gpio-test
branch
from
0252a1c to
f71e928
Compare
Signed-off-by: zhanglinjing <[email protected]>
|
I searched and recalled what open-drain output mode is: set the pin to HIGH in open-drain mode puts the pin in a high-impedance state. To pass the test, it assumes the presence of an internal/external pull-up resistor on the line to ensure the pin is set to high. That is why I consider disable HIGH check for that test case. |
jaenrig-ifx
approved these changes
Apr 14, 2025
ramya-subramanyam
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
some documentation or minor fix after running the test for xmc4arduino 4.x
Related Issue
None
Context