Add spi #32
Open
Add spi #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and test_main.ino. Signed-off-by: Frederikwag <[email protected]>
jaenrig-ifx
requested changes
May 7, 2025
| @@ -13,7 +15,7 @@ | |||
|
|
|||
| // defines | |||
| // Variables for SPI testing | |||
| static SPIClassPSOC *spi = nullptr; | |||
| static SPIClass *spi = nullptr; | |||
There was a problem hiding this comment.
Good try 😬
Now this is fixed for xmc-for-arduino, but it won´t work for arduino-core-psoc.
The tests are meant to be reusable across cores. So when we identify that some core specific implementation is present, we should:
- generalize it using any standard common API.
- If generalization is not possible, use some mechanism to conditionally set certain specialization. For example, use the preprocessor to identify the core -> https://github.com/Infineon/arduino-core-tests/blob/main/src/corelibs/uart/test_uart_tx.cpp#L151-L163
| @@ -5,6 +5,8 @@ | |||
| * MISO pin for the test cases to work as expected. | |||
| */ | |||
|
|
|||
| // THIS IS THE BRANCH ADD_SPI | |||
| @@ -70,7 +72,7 @@ TEST_IFX(spi_connected1_loopback, test_spi_mode_configuration) { | |||
| TEST_IFX(spi_connected1_loopback, test_spi_reinitialization) { | |||
| spi->end(); | |||
| spi->begin(); | |||
| TEST_ASSERT_EQUAL_MESSAGE(CY_RSLT_SUCCESS, spi->status, "SPI reinitialization failed"); | |||
| TEST_ASSERT_TRUE_MESSAGE(true, "SPI reinitialization completed"); | |||
There was a problem hiding this comment.
This test might not be available for the standard Arduino coreAPI?
| */ | ||
|
|
||
| // std includes | ||
| #include <tlx5012-arduino.hpp> |
There was a problem hiding this comment.
It might not be easy to test the 3-wire SPI interface... But this is not a 3wire SPI test, it is a TLE5012 test. Of course, if it works, then the affected 3-wire spi functionalities are as well validated.
We should be using the 3wire spi class and functions for it to belong in this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Added the 3 wire test for SPI. 3 tests are executed:
Related Issue
The test requires the sensor tlx5012. Later on, we need to "professionalize" it so that it communicates with another board. Setting up the XMC as slave is the critical part.
Context