-
Notifications
You must be signed in to change notification settings - Fork 8
Compile example reusable wflow #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces a reusable workflow for compiling library examples by integrating the "Compile library examples" workflow from arduino-devops and providing an optional configuration file (ci-matrix-config.yml) to extend the default fqbn matrix for libraries. Key changes include:
- Adding a ci-matrix-config.yml file that includes an esp32 board, defines exclusions for certain sketches, and adds an additional URL for core installation.
- Creating a compile_examples.yml workflow that reuses the compile-examples-lib workflow from the Infineon/arduino-devops repository.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
ci-matrix-config.yml | Adds custom inclusion and exclusion rules for board fqbn configurations and additional URL for esp32 core setup |
.github/workflows/compile_examples.yml | Introduces a reusable workflow that leverages the compile-examples-lib workflow from the Infineon/arduino-devops repo |
Files not reviewed (1)
- .github/workflows/build-check.yml: Language not supported
I would say we start like this and see if it's sufficient. I assume yes.
This is fine. Our main metric is based on repo views, not release download numbers. Why are secrets needed for this workflow? |
Let me check if that is needed :) |
7229dce
to
a0e2754
Compare
…es workflow. Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
…sion. Signed-off-by: jaenrig-ifx <[email protected]>
a0e2754
to
1cde631
Compare
Before merging this, can you please have a look at these workflow call conditions? Requirements:
|
I will add them, but directly to this wflow (as they are not meaningful or possible in the reusable wflow):
I think we can get rid of the "develop" branch or? |
Yes, I do mean
Did you look into the reference file above? My recommendation from there:
What's your recommendation?
Yes. |
Signed-off-by: jaenrig-ifx <[email protected]>
👍 |
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
This is the proposal for reusable compile-examples workflow for libraries:
Added reusable "Compile library examples" workflow from "arduino-devops" -> https://github.com/Infineon/arduino-devops/blob/compile-examples-lib/.github/workflows/compile-examples-lib.yml.
The "ci-matrix-config.yml" file is optional. If not added to the project, the default "fqbn" matrix will be used -> https://github.com/Infineon/arduino-devops/blob/compile-examples-lib/config/ci-config-matrix-ifx-lib.yml
In this case, the "ci-matrix-config.yml" is used, to extend or modify the default Infineon "fqbn" matrix for libraries. Specifically, we have added the esp32 board which was added in the previous build check, and exclude from the sketch-fqbn combinations which are not supported.
Open questions to @ederjc :
We can implement that mechanism, but we can maybe reuse the flow we implement for release candidates check. What do you think?
I need to cleanup and document the scripts in "arduino-devops". Meanwhile I keep this as draft.