Skip to content

Accessibility enhancement added to IconButton #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

agata-kim
Copy link
Collaborator

@agata-kim agata-kim commented Apr 17, 2025

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Added area-label and area-disabled to IconButton to enhance accessibility.

Related Issue
#1264

Context
Accessibility enhancement

📦 Published PR as canary version: 33.1.2--canary.1826.0a858592c19f502a4989676992b5208d02e799a9.0

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@33.1.2--canary.1826.0a858592c19f502a4989676992b5208d02e799a9.0
# or 
yarn add @infineon/infineon-design-system-stencil@33.1.2--canary.1826.0a858592c19f502a4989676992b5208d02e799a9.0

@agata-kim agata-kim linked an issue Apr 17, 2025 that may be closed by this pull request
@agata-kim agata-kim requested a review from verena-ifx April 17, 2025 14:01
Copy link
Contributor

github-actions bot commented Apr 17, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://Infineon.github.io/infineon-design-system-stencil/pr-preview-angular-example/pr-1826/

Built to branch gh-pages at 2025-04-24 10:37 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link
Contributor

--STORYBOOK-PREVIEW--

@agata-kim agata-kim self-assigned this Apr 22, 2025
@agata-kim agata-kim changed the title Added accessibility to IconButton Accessibility enhancement added to IconButton Apr 22, 2025
Copy link
Contributor

@verena-ifx verena-ifx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok Same topic as with the link. Please user lowercase for the properties

@agata-kim
Copy link
Collaborator Author

Cannot rename AreaLabel because we extend HTMLStencilElement and it must be identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility enhancement
2 participants