Accessibility enhancement added to Link #1827
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agata-kim
changed the title
|
|
--STORYBOOK-PREVIEW--
|
…129bb536649b389971d5464b1.0
|
--EXAMPLE-APPS-PREVIEW--
|
verena-ifx
requested changes
Apr 24, 2025
| @@ -9,7 +9,8 @@ export default { | |||
| size: 'm', | |||
| disabled: false, | |||
| variant: 'bold', | |||
| download: "" | |||
| download: "", | |||
| AriaLabel: 'Link', | |||
There was a problem hiding this comment.
could you change this to be lowercase? just to be consistent here
| @@ -88,7 +100,7 @@ export default { | |||
| }; | |||
|
|
|||
| const DefaultTemplate = args => | |||
| `<ifx-link href="${args.href}" target="${args.target}" size="${args.size}" variant="${args.variant}" disabled="${args.disabled}" download="${args.download}" > | |||
| `<ifx-link href="${args.href}" aria-label="${args.AriaLabel}" target="${args.target}" size="${args.size}" variant="${args.variant}" disabled="${args.disabled}" download="${args.download}" > | |||
| ${args.label} | |||
| @@ -15,6 +15,7 @@ export class Link { | |||
| @Prop() size: string; | |||
| @Prop() disabled: boolean = false; | |||
| @Prop() download: string; | |||
| @Prop() AriaLabel: string; | |||
There was a problem hiding this comment.
AriaLabel should be lowercase > ariaLabel
…com/Infineon/infineon-design-system-stencil into 1264-accessibility-enhancement-link
…2a7191e77c8327f1a89e582c7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Made link focusable if href is not empty. Added keyboard navigation and aria-label property.
Related Issue
#1264
Context
Accessibility enhancement
📦 Published PR as canary version:
33.1.2--canary.1827.d19d80549c3441a2a7191e77c8327f1a89e582c7.0✨ Test out this PR locally via:
npm install @infineon/infineon-design-system-stencil@33.1.2--canary.1827.d19d80549c3441a2a7191e77c8327f1a89e582c7.0 # or yarn add @infineon/infineon-design-system-stencil@33.1.2--canary.1827.d19d80549c3441a2a7191e77c8327f1a89e582c7.0