Fixed clippy warnings (Rust release 1.88) #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes formatting calls to address Clippy warnings by leveraging Rust’s inline named interpolation (Rust 1.88).
- Replaced positional
format!arguments with inline{var}syntax across error messages, template filters, and file paths. - Updated
execute_template, peripheral module generators, and build script to use inline formatting in panics and logging. - Aligned environment variable printing in
build.rsto inline formatting.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/rust_gen/xml2ir.rs | Updated multiple format! calls for error messages to inline variables. |
| src/rust_gen.rs | Replaced positional formatting in filters and template writers with inline interpolation. |
| build.rs | Adjusted println! for AURIX_TOOLCHAIN to inline formatting. |
Co-authored-by: Copilot <[email protected]>
andreasWallnerIFX
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed clippy warnings
--- please keep the agreement as part of the PR text ---
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/svd2pac/blob/main/CONTRIBUTING.md
CONTRIBUTING.md also tells you what to expect in the PR process.