-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(ui): scroll layout issue on zoom #3432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes update the CSS class names on the main container divs in both the Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR fixes scrolling and layout issues on the Login and Sign Up pages, particularly when zoomed in or on smaller screens, by adjusting CSS classes to ensure proper content visibility and scrolling behavior.
- Modified
LoginPage.tsx
to replacejustify-center
withitems-center
for better vertical alignment - Updated
SignUpPage.tsx
layout to ensure all input fields are visible and scrollable - Fixed signup button cutoff issue on desktop displays (issue Signup button cutoff on desktop display #1411)
- Resolved small screen visibility problems that previously required zooming to 67% (issue Sign up page is not showing all input fields on small screens #1576)
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Description 📣
This PR fixes a layout issue where scrolling only worked when zoomed in.
resolves issues #1411 #1576
Type ✨
Tests 🛠️
previous behaviour : https://www.loom.com/share/54494c7b4fc44491a94a16c9e4ffbe50?sid=d3c90686-59f3-4993-b6ce-71886bb8409e
aftex fix : https://www.loom.com/share/d9d0e2d58f76474fb6a7ce946b2a2c53?sid=b3bcedf1-d2c8-434d-87f6-10c7a49ed5fb
# Here's some code block to paste some code snippets
Summary by CodeRabbit