[Windows] Crash serveur - Exception in the LocalFileSystemObserverWorker #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopheLarchier
changed the title
ClementKunz
reviewed
Nov 14, 2025
| try { | ||
| pzwQueryDirectoryFile = (PZW_QUERY_DIRECTORY_FILE) GetProcAddress(hModule, "ZwQueryDirectoryFile"); | ||
| } catch (const std::exception &e) { | ||
| LOG_WARN(Log::instance()->getLogger(), "Exception in GetProcAddress: err=" << e.what()); |
Contributor
There was a problem hiding this comment.
Maybe force the value of ioError to something (ex: Unknown). If I understand the code correctly, ioError is still equal to Success here and the log message on line 176 might be misleading.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly in GetFileStat or GetNodeId.
GetProcAddress can throw an exception if the first parameter, GetModuleHandle(L”ntdll.dll”), is null, which can happen in case of OS corruption or if the function is not found (ERROR_PROC_NOT_FOUND).