feat: Public cloud Project #69
Conversation
tomatobet
added
the
awaiting api changes
|
|
Pure Unit test coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0ab76ea |
|
Global test coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0ab76ea |
📊 Test Reports Available🔍 Unit Test Results: View Detailed Report 🔍 Acceptance Mocked Test Results: View Detailed Report 📦 Download archive test reports to see details |
| data "infomaniak_project" "create_project" { | ||
| public_cloud_id = var.infomaniak.cloud_id | ||
| id = var.infomaniak.project_id | ||
| } | ||
| */ |
There was a problem hiding this comment.
nit: you can delete this if it not used
| token = var.infomaniak.token | ||
| } | ||
|
|
||
| resource "infomaniak_project" "create_project" { |
There was a problem hiding this comment.
maybe rename the resource name "infomaniak_public_cloud_project". "infomaniak_project" is not very explicit
| Kaas kaas.Api | ||
| Domain domain.Api | ||
| DBaas dbaas.Api | ||
| Project project.Api |
There was a problem hiding this comment.
Same for variables and package, maybe something where we understand it is a public cloud project
| r.client = client | ||
| } | ||
|
|
||
| func (r *projectDataSource) Schema(ctx context.Context, _ datasource.SchemaRequest, resp *datasource.SchemaResponse) { |
There was a problem hiding this comment.
Now we put schemas inside separates files named xxx_schema.go. You can see an example on dbaas PR
| r.client = client | ||
| } | ||
|
|
||
| func (r *projectResource) Schema(ctx context.Context, req resource.SchemaRequest, resp *resource.SchemaResponse) { |
There was a problem hiding this comment.
Same here, we now put schema in a separate file
|
Really nice PR, it's really cool to be able to manage public cloud projects directly from terraform ! |
Add a resource and a datasource to manage public cloud projects