Skip to content

Conversation

@yyewolf
Copy link
Member

@yyewolf yyewolf commented Nov 17, 2025

This pull request makes a small but important change to the fill method in dbaas_resource.go. The change ensures that connection-related fields are only set if the Connection object is not nil, preventing potential nil pointer errors.

  • Only populate the Host, Port, User, Password, and Ca fields in the model if dbaas.Connection is not nil, improving code safety.

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Pure Unit test coverage

File Coverage
All files 2%
internal/services/dbaas/dbaas_resource.go 0%
internal/services/dbaas/dbaas_resource.go 0%
internal/services/dbaas/dbaas_resource.go 0%

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against 3b9af2e

@github-actions
Copy link
Contributor

Global test coverage

File Coverage
All files 38%
internal/services/dbaas/dbaas_resource.go 2%
internal/services/dbaas/dbaas_resource.go 0%

Minimum allowed coverage is 10%

Generated by 🐒 cobertura-action against 3b9af2e

@github-actions
Copy link
Contributor

📦 Download test reports to see details

@yyewolf yyewolf merged commit eccb8c6 into fix/api-route-changes Nov 17, 2025
9 checks passed
@yyewolf yyewolf deleted the fix/dbaas/nil-pointer branch November 17, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants