forked from improbable-eng/grpc-web
-
Notifications
You must be signed in to change notification settings - Fork 2
chore: fix nuked nhooyr/websocket dependency #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxim-inj
wants to merge
1
commit into
InjectiveLabs:master
Choose a base branch
from
maxim-inj:chore/bump-mod
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ import ( | |
| "net/http" | ||
| "time" | ||
|
|
||
| "nhooyr.io/websocket" | ||
| "github.com/coder/websocket" | ||
| ) | ||
|
|
||
| var ( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ import ( | |
| "sync" | ||
| "time" | ||
|
|
||
| "nhooyr.io/websocket" | ||
| "github.com/coder/websocket" | ||
|
|
||
| "crypto/tls" | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Ensure import grouping and remove old websocket import.
The new import
"github.com/coder/websocket"is correctly added but it's currently splitting standard library imports (e.g., it sits before"crypto/tls"). Consider moving it to the external dependencies block (after all stdlib imports) to abide by import grouping conventions. Also verify that all occurrences of the old"nhooyr.io/websocket"import have been removed across the codebase.Run:
🏁 Script executed:
rg -n "nhooyr.io/websocket"Length of output: 205
🏁 Script executed:
Length of output: 2599
Import grouping: move
github.com/coder/websocketinto the external imports blockVerified that there are no remaining code references to
nhooyr.io/websocket(only a mention in CHANGELOG.md). Please adjust the import order so that all stdlib imports—including"crypto/tls"—are grouped together, followed by third-party imports:go/grpcwebproxy/main.go:
import ( "fmt" "log" "net" "net/http" _ "net/http/pprof" // register in DefaultServerMux "os" "sync" "time" - "github.com/coder/websocket" "crypto/tls" + "github.com/coder/websocket" grpc_middleware "github.com/grpc-ecosystem/go-grpc-middleware" grpc_logrus "github.com/grpc-ecosystem/go-grpc-middleware/logging/logrus" grpc_prometheus "github.com/grpc-ecosystem/go-grpc-prometheus" … )📝 Committable suggestion