Feat : Validation 추가 및 테스트코드 추가 #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: 다형성 적용을 통한 Entity/DTO 구조 개선 및 테스트 코드 리팩토링
heli-os
force-pushed
the
koodongha-onboarding-6
branch
from
4ba50b0 to
dba2fba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Validation 추가, 테스트코드 추가
Changes
Validation을 Dto에 추가하여 잘못된 요청을 Controller에 들어오기 전에 걸러내었으며,
일부 Controller와 전역 예외 처리 로직에 대한 단위 테스트 추가했습니다.
Description
간단하게만 처음에 데이터를 구성했는데, 질문이나 응답 수가 늘어날 경우를 고려해
main에서 다시 branch를 딴 후 쿼리최적화부터 하려 합니다.