-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention how Siemens applies some patterns #801
Conversation
💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines. If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁
This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace. |
Signed-off-by: Florian Greinacher <[email protected]> Co-authored-by: Nejc Habjan <[email protected]>
07ce37b
to
e549bc5
Compare
@spier As promised, here you go :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, thank you for this. I especially like the short explanations!
I left some inline comments for you.
FYI I recently filed #799 after re-watching the recording of your FOSS Backstage talk. I think you PR here covers the quick wins already. Let's aim to get this one merged quickly, and then move any potential further topics to future issues/PRs.
@@ -108,6 +108,7 @@ It is a good solution for a portal with a few dozen projects, though. | |||
* **Mercado Libre** use an instance of the [SAP portal](https://github.com/SAP/project-portal-for-innersource) to discover existing InnerSource projects within the organization. | |||
* **Mercedes-Benz** is [using](https://opensource.mercedes-benz.com/news/sponsor_innersource_commonsoss) the SAP reference implementation mentioned above for their InnerSource Portal. | |||
* **WellSky** has a simple _Confluence Wiki_ page were InnerSource and reusable projects are listed. | |||
* **Siemens** has set up an internal portal that provides documentation for InnerSource maintainers, contributors, users and their managers. It also serves as an entry point to explore available projects and gives hints to improve project visibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you comfortable sharing which tooling you are using for this? e.g. is it Backstage, a custom built site, something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the documentation portal we are using MkDocs in combination with our internal docs-theme we maintain (reused > 2400 times, also Inner Source). But we also have a dedicated app using Django and another popular innersource framework for the UI, there we have detailed re-use metrics and do also calculate the re-use, usage, quality metric and much more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional info @bufferoverflow. The measurement of re-use could even be a pattern in its own right but lets keep that for another day :) (I made a note of that)
How do you list the InnerSource projects? Do you just use the features of your gitlab instance to do that, or is there a dedicated places that shows InnerSource projects only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're listing inner source projects on a dedicated page, also including additional data mentioned by @bufferoverflow
above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The measurement of re-use could even be a pattern in its own right but lets keep that for another day :) (I made a note of that)
@spier Yes, I think that would be worth to do. It's especially useful for reporting and if people see the numbers of re-use they could imagine the savings we had due to re-use Inner Source. This really helps to convince people.
Btw through your PR I also noticed that we have some formatting inconsistencies in our patterns. I did not want to distract your PR with fixing these. Will do so separately, once this PR is merged. |
Yep, I also noticed that. I adapted to the style in each file. Maybe some linting would be helpful 😀 |
Co-authored-by: Sebastian Spier <[email protected]>
Co-authored-by: Sebastian Spier <[email protected]>
Good idea with the linter. We have a linter (based on markdownlint) but so far that only checks for the existence of the correct section titles from our pattern template. If you are curious, see pattern-template.js. I guess one could also check other formatting conventions there, just I have never done that before with markdown. If you got any, I am happy for any tips related to linting documents / markdown files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing now. Let's bring this live, and then continue the conversation about potential other patters etc.
FYI I am leaving one comment open where a little conversation with @bufferoverflow is still ongoing.
Thank you for following up on our conversation at the FOSS Backstage conference @fgreinacher ❤️ It is great to see how Siemens has applied some of these InnerSource patterns as well, proving that these are actually patterns i.e. solutions that are being re-discovered and applied in various different contexts and organizations. You can now search for the InnerSource Patterns applied at Siemens through this link: |
@spier We're also using https://github.com/DavidAnson/markdownlint?tab=readme-ov-file. There are many ways to run it and it can check most relevant things! |
This adds some instances to patterns we are applying at @siemens.
/cc @deveaud-m @bufferoverflow @nejch