Improve populate command by handling new fields in models #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lymkwi
reviewed
Jan 10, 2024
Contributor
Lymkwi
left a comment
Lymkwi
left a comment
There was a problem hiding this comment.
Only small concern, and I've got to run it once for tests. Otherwise, so far so good.
| maxTeam=randint(1, 10), | ||
| logo=self.generate_logo(), | ||
| is_announced=randint(0, 100) < 50, | ||
| player_price_online=randint(0, 50), |
Contributor
There was a problem hiding this comment.
prices are not int, they are Decimal. Are you sure the conversion is done when this is assigned?
Member
Author
There was a problem hiding this comment.
It was in my testing but it could be better for testing to have Decimal, i will change it soon 👍
Lymkwi
reviewed
Feb 15, 2024
Lymkwi
suggested changes
Feb 15, 2024
Contributor
Lymkwi
left a comment
Lymkwi
left a comment
There was a problem hiding this comment.
- there was a comment about decimals
- you should probably fix the generation of random stuff in the tournament name, apparently it's breaking length constraints at the moment?
Member
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes but still useful to test with empty DB.