BUG: Include find GTest CMake code when installed#4966
BUG: Include find GTest CMake code when installed#4966blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
github-actions
bot
added
type:Bug
|
The GTest libraries should not be a build time dependency of an installed ITK, but not sure how to disable the GTest libraries in an installed ITK. |
| endif() | ||
| ") | ||
| set(ITKGoogleTest_EXPORT_CODE_INSTALL " | ||
| set(GTEST_ROOT \"${GTEST_ROOT}\") |
There was a problem hiding this comment.
The install tree is relocatable so we shouldn't set GTEST_ROOT since GTest might not be in the same place after deployment.
One needs to make sure nothing depends on them publicly. Then they shouldn't need to be installed. |
In all "itk-module.cmake" files, if used, it is under "TEST_DEPENDS". |
|
Off the top of my head I don't see why |
Even if GTest is not an exported public or private dependency it may still be used by application if all the ITK modules are selected for use.
blowekamp
force-pushed
the
googletest_system
branch
from
0b46c4e to
3298906
Compare
hjmjohnson
left a comment
hjmjohnson
left a comment
There was a problem hiding this comment.
This seems reasonable to me.
|
@blowekamp should this be integrated? |
thewtex
modified the milestones:
ITK 6.0 Beta 1,
Backlog -- Will be considered for future releases
4 participants
May address: #303
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.