ENH: Add LinearImageFunction wrapping test#5310
Draft
dzenanz wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Draft
ENH: Add LinearImageFunction wrapping test#5310dzenanz wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
dzenanz wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
Based on code provided on the forum: https://discourse.itk.org/t/improper-wrapping-of-imagefunction-isinsidebuffer/7495
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new Python test file to verify the behavior of LinearImageFunction’s various IsInsideBuffer overloads as wrapped by ITK.
- Introduces a test script that exercises list, continuous index, and point-based inputs to IsInsideBuffer.
- Ensures that the Python wrapping for LinearImageFunction works as intended.
Files not reviewed (1)
- Modules/Core/ImageFunction/wrapping/test/CMakeLists.txt: Language not supported
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| # ==========================================================================*/ |
There was a problem hiding this comment.
[nitpick] The trailing '*/' appears to be an artifact from another language's comment style. Consider removing it to maintain consistency with Python comment formatting.
Suggested change
| # ==========================================================================*/ | |
| # ========================================================================== |
Member
Author
There was a problem hiding this comment.
Spotted immediately by a fresh set of eyes 😄
Member
Author
There was a problem hiding this comment.
I copied this from another test, so this is not an isolated instance.
Member
Author
|
On the CI, the test fails with a different error message: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on code provided on the forum: https://discourse.itk.org/t/improper-wrapping-of-imagefunction-isinsidebuffer/7495
PR Checklist