ENH: Implement PEP 688 buffer protocol for ITK Python#5673
Draft
ENH: Implement PEP 688 buffer protocol for ITK Python#5673
Conversation
Co-authored-by: thewtex <25432+thewtex@users.noreply.github.com>
Co-authored-by: thewtex <25432+thewtex@users.noreply.github.com>
Co-authored-by: thewtex <25432+thewtex@users.noreply.github.com>
Co-authored-by: thewtex <25432+thewtex@users.noreply.github.com>
…king Co-authored-by: thewtex <25432+thewtex@users.noreply.github.com>
Co-authored-by: thewtex <25432+thewtex@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing tests and refine implementation for ITK PR #5665
ENH: Implement PEP 688 buffer protocol for ITK Python
Dec 5, 2025
blowekamp
reviewed
Dec 8, 2025
|
|
||
| # Get the memoryview from PyBuffer using the existing C++ method | ||
| # This returns a 1-D memoryview of the raw buffer | ||
| raw_memview = PyBufferType._GetArrayViewFromImage(self) |
Member
There was a problem hiding this comment.
The original PR, got a buffer from the import image container. This added a daisy chained reference to the object which actually holds the C buffer. This may help keep the Python buffer valid in some cases.
If this is not used, then perhaps the ImportImageContainer buffer interface should be removed. As I recall it was not properly wrapped for complex/composite pixel types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements PEP 688 buffer protocol support for ITK Images and ImportImageContainers, enabling zero-copy NumPy interoperability in Python 3.12+. Based on #5665 by @blowekamp with fixes for test failures and implementation refinements.
Key changes:
PyBuffer::_GetMemoryViewFromImportImageContainer()with overflow checking__buffer__()methods: Implemented forImageandImportImageContainerclassesPyBuffer._GetArrayViewFromImage()_get_formatstring()for robustnessImportImageContainer, CMake macro application__array__()uses buffer protocol for Python 3.12+, falls back toarray_from_image()otherwiseUsage:
PR Checklist
Related:
Co-authored-by: Bradley Lowekamp blowekamp@users.noreply.github.com
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.