STYLE: Remove redundant casting for same types#5807
Merged
Conversation
Contributor
|
Interesting, thanks Hans! How did you find these cases? Two minor comments regarding the commit subject line, "ENH: remove redundant casting for same types"
Regarding the commit message itself:
What do you mean by "subsequently recommend their removal"? |
Remove explicit type casting operations that involve the same source and destination types. Covers a range of explicit casting operations, including static_cast, const_cast, C-style casts, and reinterpret_cast. Its primary objective is to enhance code readability and maintainability by eliminating unnecessary type casting. Cases found by clang-tidy https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-casting.html
dd8e5fe to
4daf532
Compare
Member
Author
|
Fixed comments. Cases found by clang-tidy |
dzenanz
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STYLE: Remove redundant casting for same types
Remove explicit type casting operations that involve the same source and
destination types. Covers a range of explicit casting operations,
including static_cast, const_cast, C-style casts, and
reinterpret_cast. Its primary objective is to enhance code
readability and maintainability by eliminating unnecessary
type casting.
Cases found by clang-tidy
https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-casting.html
PR Checklist