Skip to content

Conversation

@jcfr
Copy link
Collaborator

@jcfr jcfr commented Jan 27, 2025

This ensures that installed itk-ants wheels have been build with _GLIBCXX_USE_CXX11_ABI=0 to match the ABI also used to build Slicer official binaries.

For more details, see Slicer/Slicer#8168

… build

This ensures that installed itk-ants wheels have been build with
`_GLIBCXX_USE_CXX11_ABI=0` to match the ABI also used to build Slicer
official binaries.

For more details, see Slicer/Slicer#8168
@jcfr jcfr linked an issue Jan 27, 2025 that may be closed by this pull request
@jcfr
Copy link
Collaborator Author

jcfr commented Jan 27, 2025

cc: @muratmaga

@jcfr
Copy link
Collaborator Author

jcfr commented Jan 27, 2025

On Windows, the test itkANTsGroupwiseRegistrationTestFacesDirectSyN is failing12.

Details available here: https://open.cdash.org/tests/1895302684

@dzenanz Since we didn't change any code, I am wondering if the issue is related to some random generator not being consistently seeded ?

Footnotes

  1. https://github.com/InsightSoftwareConsortium/ITKANTsWasm/actions/runs/12994064830/job/36237689343?pr=36#step:15:13461

  2. https://open.cdash.org/viewTest.php?onlyfailed&buildid=10171644

@dzenanz
Copy link
Member

dzenanz commented Jan 27, 2025

Some of the test occasionally fail. I added random seeds. It helped, but is not enough. There many sources of non-determinism.

@jcfr
Copy link
Collaborator Author

jcfr commented Jan 27, 2025

Considering that this pull request did not introduce any code changes, once the workflows all complete and assuming there are no other issues, would you be okay with me merging despite of the reported failure ? Or would you prefer I re-trigger the windows workflow ?

@dzenanz
Copy link
Member

dzenanz commented Jan 27, 2025

I prefer re-triggering, but you could do either.

@jcfr
Copy link
Collaborator Author

jcfr commented Jan 27, 2025

prefer re-triggering

Noted, I will then re-trigger the failed workflows.

@jcfr jcfr merged commit 46e6827 into InsightSoftwareConsortium:main Jan 28, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Slicer integration enabling build of manylinux_2_17_x86_64 wheels

2 participants