Merged
Conversation
Member
hjmjohnson
commented
Jan 26, 2025
hjmjohnson
commented
- STYLE: Add itkVirtualGetNameOfClassMacro + itkOverrideGetNameOfClassMacro
- STYLE: CoordRepType -> CoordinateType code readability
hjmjohnson
force-pushed
the
use-CoordinateType
branch
2 times, most recently
from
9c978bd to
eb18d25
Compare
For the sake of code readability, a new 'CoordinateType' alias is added for each nested 'CoordRepType' alias. The old 'CoordRepType' aliases will still be available with ITK 6.0, but it is recommended to use 'CoordinateType' instead. The 'CoordRepType' aliases will be removed when 'ITK_FUTURE_LEGACY_REMOVE' is enabled. Similarly, 'InputCoordinateType', 'OutputCoordinateType', and 'ImagePointCoordinateType' replace 'InputCoordRepType', 'OutputCoordRepType', and 'ImagePointCoordRepType', respectively.
MeshNoise/test/itkAdditiveGaussianNoiseMeshFilterTest.cxx:56:20:
error: no viable conversion from 'const double' to 'VectorType' (aka 'Vector<float, 3U>')
56 | sphere->SetScale(SPHERE_SCALE);
| ^~~~~~~~~~~~
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
9706a92 to
93abee7
Compare
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
93abee7 to
52f7dfa
Compare
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
5d35fcc to
c1ef961
Compare
jhlegarreta
reviewed
Mar 16, 2025
Member
jhlegarreta
left a comment
jhlegarreta
left a comment
There was a problem hiding this comment.
In commit 0d36c3e,
Replace keyword of "ITK" with lowercase "itk"
in some instances to be consistent.
I do not see the change neither in this commit or other commits within the PR. Were the changes meant to be included or should the commit message be changed?
Thanks for doing this Hans.
In preparation for release. Ensure that cmake is 3.16.3 or greater to match v5.4.2 minimum requirements. Set minimum python to 3.9 Increment version number.
Set the default build package tags to v5.4.2 for capturing the ITKRemoteModuleBuildTestPackageAction shared scripts. This pulls the default configuration items needed to build against ITK version v5.4.2.
Match the ITK version minimum requirements for cmake.
Match version for ITK v5.4.2
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
1d2e76c to
f646c50
Compare
Member
Author
It was an issue in other remote modules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.