Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform when vector api is present but not used #3139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@
import jdk.incubator.vector.ShortVector;
import jdk.incubator.vector.VectorMask;
import jdk.incubator.vector.VectorOperators;
import org.apache.logging.log4j.Logger;

import javax.annotation.Nullable;

public class SimdSupport {

private static final Logger LOGGER = LogManagerCompat.getLogger();
private static final boolean VECTOR_API_PRESENT;

static {
Expand All @@ -32,8 +34,16 @@ public class SimdSupport {
}
VECTOR_API_PRESENT = vectorApiPresent;
if (!VECTOR_API_PRESENT && Settings.settings().EXPERIMENTAL.USE_VECTOR_API) {
LogManagerCompat.getLogger()
.warn("FAWE use-vector-api is enabled but --add-modules=jdk.incubator.vector is not set.");
LOGGER.warn("""
FAWE use-vector-api is enabled but --add-modules=jdk.incubator.vector is not set.
Vector instructions will not be used.
""");
} else if (VECTOR_API_PRESENT && !Settings.settings().EXPERIMENTAL.USE_VECTOR_API) {
LOGGER.warn("""
The server is running with the --add-modules=jdk.incubator.vector option.
FAWE can use vector instructions, but it is disabled in the config.
Enable use-vector-api to benefit from vector instructions with FAWE.\
""");
}
}

Expand Down
Loading