-
-
Notifications
You must be signed in to change notification settings - Fork 847
feat: Add DisableBlockUpdateFlag #4569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add DisableBlockUpdateFlag #4569
Conversation
I don't know if getting this specific with block physics should be in P2? I feel like the condition for not updating blocks is quite arbitrary, and doesn't really serve much of a purpose to the plot itself, and is rather something that should be player-specific based on that player's preferences |
Hi @dordsor21, thanks for your response I can understand your point of view in a context other than creative. |
@@ -556,6 +556,7 @@ | |||
"flags.flag_description_concrete_harden": "<gray>Set to `false` to disable concrete powder forming to concrete with water.</gray>", | |||
"flags.flag_description_device_interact": "<gray>Set to `true` to allow devices to be interacted with in the plot.</gray>", | |||
"flags.flag_description_disable_physics": "<gray>Set to `true` to disable block physics in the plot.</gray>", | |||
"flags.flag_description_disable_block_update": "<gray>Set to `true` to disable block update in the plot.</gray>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"flags.flag_description_disable_block_update": "<gray>Set to `true` to disable block update in the plot.</gray>", | |
"flags.flag_description_disable_block_update": "<gray>Set to `true` to disable block updates in the plot, e.g. breaking of flowers when the block below is removed.</gray>", |
return; | ||
} | ||
if (!sourceBlock.getType().name().toLowerCase(Locale.ROOT).contains("snow") | ||
|| !block.getLocation().add(0, -1, 0).getBlock().getType().equals(Material.GRASS_BLOCK)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this is a massively specific implementation. It should be an "all or nothing" which is why I question its inclusion; this might be how you want it, but it's not necessarily how others might want it to be implemented. This is why I suggest it might make better sense in a separate plugin where it is configurable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For which practical creative construction use-case was this implemented? I would also say that “no block update” does not need any filter.
Description
Challenge
Using the current
disable-physics
flag doesn't suit all needs.I'm missing a flag that prevents blocks around one that I'm updating from being updated.
There are several examples:
Resolution
In this PR, I've added the
disable-block-update
flag to disable block updating when blocks are updated. The default value isfalse
because there shouldn't be any change in the update behaviour on a plot without a flag.Two points:
disable-physics
flag because, as I see it, the two flags have their own responsibilities, one affecting the gravity of the blocks and the other the update.Submitter Checklist
@since TODO
.