Add entity cap check of armor stands & end crystals into player interact listener #4654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er interact listener When cancelled in the creature spawn event and placed by a player, the player will lose the armor stand / end crystal item from their inventory. This PR aims to fix this by moving the verification whether the entity should be cancelled up to the spawn egg right click, this way the item is not touched. I tried my best to verify this is not breaking anything; I'm not sure if the original code in EntitySpawnListener should be kept? Reviews appreciated. Signed-off-by: FlorianMichael <[email protected]>
|
I assume moving this check isn't okay. Spawning should also be prevented when caused by e.g. dispensers, throwing eggs, etc. |
If the entity is not spawned by the player, this check is still needed Signed-off-by: FlorianMichael <[email protected]>
FlorianMichael
changed the title
|
@SirYwell Hm yeah, I forgot that. Added the original code back now, this way it's cancelled on interaction level when the player spawns the entity and otherwise on creature spawn level. |
dordsor21
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When cancelled in the creature spawn event and placed by a player, the player will lose the armor stand / end crystal item from their inventory. This PR aims to fix this by moving the verification whether the entity should be cancelled up to the spawn egg right click, this way the item is not touched.
I tried my best to verify this is not breaking anything; I'm not sure if the original code in EntitySpawnListener should be kept? Reviews appreciated.
Submitter Checklist
@since TODO.