Skip to content

Guard unset CRITICAL_PREFIXES in coverage config #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
negillett merged 2 commits into from
May 30, 2026
Merged

Guard unset CRITICAL_PREFIXES in coverage config #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
917afbd
Guard unset CRITICAL_PREFIXES in coverage config
May 30, 2026
d9f5de7
Fix CRITICAL_PREFIXES guard syntax in coverage script
May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions scripts/check-coverage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,16 @@ fi

if [[ -n "${CRITICAL_RULES:-}" ]]; then
printf '%s\n' "${CRITICAL_RULES[@]}" >"$rules_file"
elif [[ -n "${CRITICAL_MIN:-}" && ${#CRITICAL_PREFIXES[@]} -gt 0 ]]; then
while IFS= read -r prefix; do
[[ -n "$prefix" ]] || continue
printf '%s:%s\n' "$CRITICAL_MIN" "$prefix"
done < <(printf '%s\n' "${CRITICAL_PREFIXES[@]}") >"$rules_file"
elif [[ -n "${CRITICAL_MIN:-}" ]]; then
if declare -p CRITICAL_PREFIXES &>/dev/null && [[ ${#CRITICAL_PREFIXES[@]} -gt 0 ]]; then
while IFS= read -r prefix; do
[[ -n "$prefix" ]] || continue
printf '%s:%s\n' "$CRITICAL_MIN" "$prefix"
done < <(printf '%s\n' "${CRITICAL_PREFIXES[@]}") >"$rules_file"
else
echo "coverage-tiers.conf must set CRITICAL_RULES or CRITICAL_MIN + CRITICAL_PREFIXES" >&2
exit 2
fi
else
echo "coverage-tiers.conf must set CRITICAL_RULES or CRITICAL_MIN + CRITICAL_PREFIXES" >&2
exit 2
Expand Down
51 changes: 51 additions & 0 deletions scripts/check-coverage_config_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
#!/usr/bin/env bash
# Regression test: missing critical tier config yields a clear error.
set -euo pipefail

script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"

run_config_case() {
local conf_body="$1"
local label="$2"

local root
root="$(mktemp -d)"
# shellcheck disable=SC2064
trap "rm -rf '$root'" RETURN

mkdir -p "$root/scripts"
cp "$script_dir/check-coverage.sh" "$script_dir/check-coverage-aggregate.awk" \
"$root/scripts/"

cat >"$root/scripts/coverage-tiers.conf" <<EOF
${conf_body}
EOF

cat >"$root/coverage.out" <<'EOF'
mode: atomic
example.com/pkg/main.go:1.1,2.1 2 2
EOF

local output=""
local code=0
output="$(bash "$root/scripts/check-coverage.sh" "$root/coverage.out" 2>&1)" || code=$?

if [[ "$code" -ne 2 ]]; then
echo "FAIL (${label}): expected exit 2, got ${code}" >&2
echo "$output" >&2
return 1
fi

if ! grep -q "must set CRITICAL_RULES or CRITICAL_MIN + CRITICAL_PREFIXES" <<<"$output"; then
echo "FAIL (${label}): expected descriptive config error, got:" >&2
echo "$output" >&2
return 1
fi

return 0
}

run_config_case "TOTAL_MIN=90" "no critical tier keys" || exit 1
run_config_case $'TOTAL_MIN=90\nCRITICAL_MIN=95' "CRITICAL_MIN without CRITICAL_PREFIXES" || exit 1

echo "PASS: incomplete critical tier config reports clear error"
Loading