mods list search #2707
Open
mods list search #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petchema
added
enhancement
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mod list search (#2705) implementation
At first I tried to implement view filtering (only display mods that matched), but that made the semantic of "increase mod order" and "decrease mod order" buttons... complicated. Also, the mod manager relies heavily on several arrays using the same indices, so it was almost intractable.
So I implemented a simpler search; Within the UI components limitations, I added a text field, and "up" and "down" arrow to find the previous and next match. It's serviceable.