Make sure TEDIT backing files close on error#2284
Merged
rmkaplan merged 1 commit intoSep 10, 2025
Merged
Conversation
fghalasz
approved these changes
Sep 10, 2025
fghalasz
left a comment
fghalasz
left a comment
Member
There was a problem hiding this comment.
LGTM. Ran doHCFiles.yml in Github Actions as well as do_hcfiles.sh on Ubuntu 24.04 on WSL2. All runs completed successfully. Tests showed no extraneous open files during the runs.
Member
|
HCFILES now runs to completion but the formatting of the produced prettyprinted Lisp files looks off. For example, there's too much bold text. |
Contributor
Author
|
Is that generally true, or just specific files?
… On Sep 11, 2025, at 1:26 PM, Paolo Amoroso ***@***.***> wrote:
pamoroso
left a comment
(Interlisp/medley#2284)
<#2284 (comment)>
HCFILES now runs to completion but the formatting of the produced prettyprinted Lisp files looks off. For example, there's too much bold text.
—
Reply to this email directly, view it on GitHub <#2284 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJPPDBPPKSDLGVVFL233SHLILAVCNFSM6AAAAACF7VE4T6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEOBSGUZDENRRGU>.
You are receiving this because you modified the open/close state.
|
Member
|
It's generally true, it happens with all Lisp files. TEdit files look fine though. |
rmkaplan
deleted the
rmk125--Make-sure-Tedit-backing-files-close-on-error
branch
March 2, 2026 21:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2281.
The files should close on internal errors, and no textstream will be returned.