check CUDA_DEVICE_MAX_CONNECTIONS and TORCH_NCCL_AVOID_RECORD_STREAMS #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sallyjunjun
force-pushed
the
optimize-code
branch
3 times, most recently
from
74d8c7d to
91b6ad5
Compare
sallyjunjun
force-pushed
the
optimize-code
branch
2 times, most recently
from
5825926 to
6a33277
Compare
sallyjunjun
force-pushed
the
optimize-code
branch
from
6a33277 to
9a13687
Compare
sallyjunjun
force-pushed
the
optimize-code
branch
from
9a13687 to
f763177
Compare
| ), "Env var TORCH_NCCL_AVOID_RECORD_STREAMS has not been set, please set it to 1!" | ||
| assert ( | ||
| avoid_record_streams == "1" | ||
| ), "Env var TORCH_NCCL_AVOID_RECORD_STREAMS is set to {}, it should be set to 1!".format(avoid_record_streams) |
There was a problem hiding this comment.
这个函数还是放在utils/common.py文件里吧
There was a problem hiding this comment.
这个移过来也是考虑循环依赖的问题，check_cuda_env函数里面需要访问gpc获取forward_overlap_per，所以不能放在utils/common.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
In GPU environment, CUDA_DEVICE_MAX_CONNECTIONS and TORCH_NCCL_AVOID_RECORD_STREAMS should be set to 1, to achieve the best performance.
Modification
modify check_cuda_env function to assert error when CUDA_DEVICE_MAX_CONNECTIONS and TORCH_NCCL_AVOID_RECORD_STREAMS are not set correctly.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: