Skip to content

Incorporate CIP-129 #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 16, 2025
Merged

Incorporate CIP-129 #1087

merged 8 commits into from
May 16, 2025

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Mar 13, 2025

Resolves #1106

Changelog

- description: |
    Incorporate CIP-129
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  - compatible     # the API has changed but is non-breaking

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/cip-129 branch 7 times, most recently from bb4e8c0 to 1a1e7ca Compare April 30, 2025 14:07
@Jimbo4350 Jimbo4350 force-pushed the jordan/cip-129 branch 2 times, most recently from 9568077 to 509135b Compare April 30, 2025 14:55
@Jimbo4350 Jimbo4350 force-pushed the jordan/cip-129 branch 2 times, most recently from 185a47d to fd3ca6a Compare April 30, 2025 15:08
@Jimbo4350 Jimbo4350 force-pushed the jordan/cip-129 branch 2 times, most recently from 134ffe9 to 8a0772d Compare April 30, 2025 15:12
@Jimbo4350 Jimbo4350 marked this pull request as ready for review April 30, 2025 15:12
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs rebase

@Jimbo4350 Jimbo4350 force-pushed the jordan/cip-129 branch 3 times, most recently from 7912930 to 1a1ab16 Compare May 5, 2025 16:25
@Jimbo4350 Jimbo4350 requested review from a team as code owners May 5, 2025 16:25
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Jimbo4350 Jimbo4350 force-pushed the jordan/cip-129 branch 5 times, most recently from e498c98 to 36be307 Compare May 15, 2025 12:23
@Jimbo4350 Jimbo4350 enabled auto-merge May 15, 2025 14:01
@Jimbo4350 Jimbo4350 added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2025
@Jimbo4350 Jimbo4350 added this pull request to the merge queue May 16, 2025
Merged via the queue into master with commit 359074e May 16, 2025
25 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/cip-129 branch May 16, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] - Include hex and bech32 representation output for conway related commands
2 participants