Add pool operator extended key support #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
palas
requested review from
Jimbo4350,
newhoggy,
carbolymer,
smelc,
kevinhammond and
disassembler
as code owners
palas
force-pushed
the
add-pool-operator-extended-key-support
branch
2 times, most recently
from
14d7e98 to
66d2a4b
Compare
|
Push - Can we merge this? |
palas
force-pushed
the
add-pool-operator-extended-key-support
branch
from
bdccfde to
0cfd471
Compare
Jimbo4350
approved these changes
Apr 24, 2025
| @@ -86,7 +86,7 @@ data QueryCommons = QueryCommons | |||
| data QueryLeadershipScheduleCmdArgs = QueryLeadershipScheduleCmdArgs | |||
| { commons :: !QueryCommons | |||
| , genesisFp :: !GenesisFile | |||
| , poolColdVerKeyFile :: !(VerificationKeyOrHashOrFile StakePoolKey) | |||
| , poolColdVerKeyFile :: !StakePoolKeyHashSource | |||
There was a problem hiding this comment.
Not for this PR but @newhoggy we should use Vary here too.
palas
force-pushed
the
add-pool-operator-extended-key-support
branch
from
0cfd471 to
64407ea
Compare
palas
force-pushed
the
add-pool-operator-extended-key-support
branch
2 times, most recently
from
23c587f to
14f982f
Compare
palas
force-pushed
the
add-pool-operator-extended-key-support
branch
from
14f982f to
3f9e62b
Compare
|
woohoo, thx @palas |
gitmachtl
added a commit
to gitmachtl/CIPs
that referenced
this pull request
May 13, 2025
https://cips.cardano.org/cip/CIP-0005 does not specify bech32 prefixes for extended pool operator keys. These were added to cardano-api with IntersectMBO/cardano-api#781 and part of cardano-cli with IntersectMBO/cardano-cli#1091 This PR modifies CIP-0005 to define a standard set of prefixes for them. Other changes: - Added [https://github.com/gitmachtl/cardano-signer](cardano-signer) to the list of tools (acceptance criteria) - Added an entry in the Changelog table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Tries to address #1076.
Check together with: IntersectMBO/cardano-api#781
How to trust this PR
Look at the test for creating stake pool registration certificate using an extended cold key. Make sure the refactorings preserve the logic of the code and that the extensions make sense. Check the code structure is good and documentation is appropriate.
Checklist