Skip to content

Conversation

@kderme
Copy link
Contributor

@kderme kderme commented Dec 7, 2025

Description

Add your description here, if it fixes a particular issue please provide a link to the issue.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.17.0.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@kderme kderme requested a review from a team as a code owner December 7, 2025 15:10
@kderme kderme force-pushed the kderme/10.6.1 branch 2 times, most recently from 9a3338c to ea6427b Compare December 9, 2025 15:13
sgillespie
sgillespie previously approved these changes Dec 9, 2025
Copy link
Contributor

@Cmdv Cmdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of very minor things

kderme and others added 11 commits December 10, 2025 12:28
First, pin the cabal-install version to <3.16, as it does not work with
haskell-language-server 2.11, and haskell.nix doesn't yet have this
available.

Then pin all the other standard dev tools to the expected versions:

 * cabal-3.14.2.0
 * fourmolu-0.17.0.0
 * hlint-3.8
As 3.8 does not seem to work with GHC 9.10
Don't fix the hlint version in the devShell, as any given version won't
support all of our compilers. Instead we'll let the solver decide on a
version, but we'll pin it in the CI check.
Pin fourmolu and hlint to our usual versions, but only provide them in
the default devShell (9.6)
Cmdv
Cmdv previously approved these changes Dec 10, 2025
Previously, we were cross building for aarch64-linux, but
now we're running into the following problem:

    qemu: uncaught target signal 11 (Segmentation fault) - core dumped
    iserv-proxy: {handle: <socket: 5>}: GHCi.Message.remoteCall: end of file

    <no location info>: error: ghc-iserv terminated (1)

Now that we have an aarch64-linux runner, we'll just use that and we
don't have to deal with cross builds and TH.
@kderme kderme merged commit b8748fb into master Dec 11, 2025
13 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants