-
Notifications
You must be signed in to change notification settings - Fork 170
Update to node 10.6.1 #2046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update to node 10.6.1 #2046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a3338c to
ea6427b
Compare
sgillespie
previously approved these changes
Dec 9, 2025
Cmdv
requested changes
Dec 9, 2025
Contributor
Cmdv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of very minor things
cardano-db-sync/src/Cardano/DbSync/Era/Shelley/Generic/ProtoParams.hs
Outdated
Show resolved
Hide resolved
First, pin the cabal-install version to <3.16, as it does not work with haskell-language-server 2.11, and haskell.nix doesn't yet have this available. Then pin all the other standard dev tools to the expected versions: * cabal-3.14.2.0 * fourmolu-0.17.0.0 * hlint-3.8
As 3.8 does not seem to work with GHC 9.10
Don't fix the hlint version in the devShell, as any given version won't support all of our compilers. Instead we'll let the solver decide on a version, but we'll pin it in the CI check.
Pin fourmolu and hlint to our usual versions, but only provide them in the default devShell (9.6)
ea6427b to
7738fdb
Compare
Cmdv
previously approved these changes
Dec 10, 2025
Previously, we were cross building for aarch64-linux, but
now we're running into the following problem:
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
iserv-proxy: {handle: <socket: 5>}: GHCi.Message.remoteCall: end of file
<no location info>: error: ghc-iserv terminated (1)
Now that we have an aarch64-linux runner, we'll just use that and we
don't have to deal with cross builds and TH.
7738fdb to
c1ffee7
Compare
Cmdv
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add your description here, if it fixes a particular issue please provide a link to the issue.
Checklist
fourmoluon version 0.17.0.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.