Skip to content

Plutus Release 1.46.0.0 #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 14, 2025
Merged

Plutus Release 1.46.0.0 #1073

merged 5 commits into from
May 14, 2025

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented May 9, 2025

Plutus Release 1.46.0.0

@Unisay Unisay force-pushed the plutus-release/1.46.0.0 branch 2 times, most recently from 4637855 to f803b61 Compare May 9, 2025 12:50
Copy link
Member

@zliu41 zliu41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not releasing from a commit that is neither on master nor on a release branch. Let's discuss it before proceeding.

@Unisay
Copy link
Contributor Author

Unisay commented May 12, 2025

I'd prefer not releasing from a commit that is neither on master nor on a release branch. Let's discuss it before proceeding.

The commit we're releasing is on the release branch though IntersectMBO/plutus@66029b4

@zliu41
Copy link
Member

zliu41 commented May 12, 2025

Right, but there are a few issues:

  • After merging the Plutus PR, branch release/1.46.0.0 will be deleted, and the commit will become a dangling commit - subject to GC.
  • I think a more common practice is to name the release branch release/1.46, and release all minor versions (1.46.1, 1.46.2 etc.) from that branch. This is what we used to do. Let's discuss which option is better.

@Unisay
Copy link
Contributor Author

Unisay commented May 12, 2025

  • After merging the Plutus PR, branch release/1.46.0.0 will be deleted, and the commit will become a dangling commit - subject to GC.

Point taken - will make sure that release PR in the plutus repository merges that commit to master without rewriting git history (e.g. no git squash).

@Unisay Unisay requested a review from zliu41 May 12, 2025 15:20
@Unisay Unisay force-pushed the plutus-release/1.46.0.0 branch 2 times, most recently from ca194a7 to 3568770 Compare May 14, 2025 06:47
@Unisay Unisay self-assigned this May 14, 2025
@Unisay Unisay force-pushed the plutus-release/1.46.0.0 branch from 1137afd to 8732840 Compare May 14, 2025 07:39
@Unisay Unisay force-pushed the plutus-release/1.46.0.0 branch from 8732840 to 44963bb Compare May 14, 2025 07:44
@Unisay
Copy link
Contributor Author

Unisay commented May 14, 2025

Merging the PR despite failing hydra checks: github actions pass but Hydra doesn't take into account latest revisions of the random package properly.

@Unisay Unisay merged commit 45b5c81 into main May 14, 2025
8 of 53 checks passed
@Unisay Unisay deleted the plutus-release/1.46.0.0 branch May 14, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants