Skip to content

Move rewards withdrawal logic to LEDGER and bump spec #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Mar 19, 2025

Description

This PR moves the rewards withdrawal logic to LEDGER and gets rid of an ugly workaround in conformance testing.

related IntersectMBO/formal-ledger-specifications#710
close #4932

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Soupstraw Soupstraw force-pushed the jj/dereg-remove-delegs branch 3 times, most recently from 15f0b39 to 7495b81 Compare March 19, 2025 14:43
@Soupstraw Soupstraw changed the title Jj/dereg remove delegs Move rewards withdrawal logic to LEDGER and bump spec Mar 19, 2025
@Soupstraw Soupstraw marked this pull request as ready for review March 19, 2025 14:54
@Soupstraw Soupstraw requested a review from a team as a code owner March 19, 2025 14:54
@Soupstraw Soupstraw force-pushed the jj/dereg-remove-delegs branch from 7495b81 to fd062af Compare March 19, 2025 14:55
@lehins lehins force-pushed the jj/dereg-remove-delegs branch from fd062af to 1771eb2 Compare March 24, 2025 08:35
@lehins
Copy link
Collaborator

lehins commented Mar 31, 2025

Will postpone it until better times :)

@lehins lehins closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move withdrawals updating logic from CERTS to LEDGER
2 participants