-
Notifications
You must be signed in to change notification settings - Fork 170
CDDL improvements #4996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDDL improvements #4996
Conversation
daf12fe to
f070721
Compare
75adbcb to
10739f9
Compare
teodanciu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first pass on this - not easy to review, particularly the final cddl files!
Will take another look tomorrow
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Core/Binary/CDDL.hs
Show resolved
Hide resolved
5aee68a to
2eccb20
Compare
lehins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Love the new formatting, comment placing and ability to specify the order of definitions.
Nice work @Soupstraw
2eccb20 to
bfe77e1
Compare
bfe77e1 to
799676c
Compare
799676c to
e9e979b
Compare
92ae540 to
348d588
Compare
36c4f1f to
5c7ec00
Compare
a76b675 to
7ca8a70
Compare
7ca8a70 to
8491d8b
Compare
lehins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice!
Aside from rerunning plutus-preprocessor due to newer version of plutus from CHaP, this PR is ready to go.
Description
This PR uses a newer version of
cuddle, which makes it possible to manually specify the order in which Huddle definitions appear. Also some of the comments about fields are now attached to the fields themselves, instead of being printed out in a long comment in front of the definition.The pretty printer has also been improved a bit, but there are still many places where the formatting is a bit off. The pretty printer could still be improved a lot, but at least the current version is a bit closer to what I'd like it to be once it's finished.
close #4974
blocked on IntersectMBO/cardano-haskell-packages#1072
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).hie.yamlupdated (usescripts/gen-hie.sh).