Remove ConwayNewEpochPredFailure #5007
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
force-pushed
the
aniketd/remove-conwaynewepochpredfailure
branch
from
697448d to
e1e3b92
Compare
aniketd
commented
Apr 23, 2025
Soupstraw
reviewed
Apr 24, 2025
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/PrettyCore.hs
Outdated
Show resolved
Hide resolved
Soupstraw
approved these changes
Apr 24, 2025
|
I guess you can turn that check into an assertion, that way we'll be able to notice if something's wrong with the reward update in one of our tests. It seems like too expensive of a check to keep it in the production version of ledger and run it every epoch boundary. |
lehins
requested changes
Apr 30, 2025
There was a problem hiding this comment.
Removal itself looks good, but it would be nice not to loose the invariant check, so STS assertion seems like the most logical choice.
Also, could you please apply all of the exact same changes to the Shelley NEWEPOCH rule. It suffers from all the same problems.
aniketd
force-pushed
the
aniketd/remove-conwaynewepochpredfailure
branch
2 times, most recently
from
8afcdd3 to
6c32856
Compare
aniketd
force-pushed
the
aniketd/remove-conwaynewepochpredfailure
branch
from
6c32856 to
c0bf2ca
Compare
lehins
requested changes
May 5, 2025
aniketd
force-pushed
the
aniketd/remove-conwaynewepochpredfailure
branch
from
c0bf2ca to
aca97f2
Compare
lehins
requested changes
May 8, 2025
Replace the corresponding check with an assertion.
Replace the corresponding check with an assertion.
aniketd
force-pushed
the
aniketd/remove-conwaynewepochpredfailure
branch
2 times, most recently
from
003d1be to
c8b89a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4662
Checklist
Tests added or updated when needed.CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
Versions updated in.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
Version bounds in.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).