-
Notifications
You must be signed in to change notification settings - Fork 157
Ensure BabbageNonDisjointRefInputs
is only checked for PlutusV3
scripts
#5011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
500251c
to
a71d627
Compare
fbdc8e9
to
a462432
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is mostly correct, but there are some issues with correct protocol version usage.
Other than that it looks great and great job on adding a new plutus test script and solving an issue where some scritps are not applicable for all plutus versions.
eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxosSpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
6e44a0c
to
e7c6ca6
Compare
3df7fe5
to
0d5318e
Compare
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
8bfce0d
to
2f12961
Compare
136c851
to
387459d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Couple of minor suggestions, but nothing critical.
eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
758e5e1
to
622fd9c
Compare
… scripts Add majorVersionAtLeast and majorVersionAtMost Co-authored-by: Alexey Kuleshevich <[email protected]>
622fd9c
to
44de8ed
Compare
Description
This PR disables
BabbageNonDisjointRefInputs
starting from protocol version 11. This makes it possible to run PlutusV1/V2 scripts that require the same hash to appear in both the inputs and reference inputs.close #5009
close #5024
Checklist
CHANGELOG.md
files updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabal
andCHANGELOG.md
files when necessary, according to theversioning process.
.cabal
files updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh
).scripts/cabal-format.sh
).scripts/gen-cddl.sh
)hie.yaml
updated (usescripts/gen-hie.sh
).