Skip to content

Ensure BabbageNonDisjointRefInputs is only checked for PlutusV3 scripts #5011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Apr 28, 2025

Description

This PR disables BabbageNonDisjointRefInputs starting from protocol version 11. This makes it possible to run PlutusV1/V2 scripts that require the same hash to appear in both the inputs and reference inputs.

close #5009
close #5024

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Soupstraw Soupstraw force-pushed the jj/revert-non-disjoint-check branch 17 times, most recently from 500251c to a71d627 Compare May 7, 2025 12:56
@Soupstraw Soupstraw marked this pull request as ready for review May 7, 2025 12:56
@Soupstraw Soupstraw requested a review from a team as a code owner May 7, 2025 12:56
@Soupstraw Soupstraw force-pushed the jj/revert-non-disjoint-check branch 8 times, most recently from fbdc8e9 to a462432 Compare May 8, 2025 14:46
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is mostly correct, but there are some issues with correct protocol version usage.
Other than that it looks great and great job on adding a new plutus test script and solving an issue where some scritps are not applicable for all plutus versions.

@Soupstraw Soupstraw force-pushed the jj/revert-non-disjoint-check branch 2 times, most recently from 6e44a0c to e7c6ca6 Compare May 12, 2025 14:24
@Soupstraw Soupstraw force-pushed the jj/revert-non-disjoint-check branch 2 times, most recently from 3df7fe5 to 0d5318e Compare May 12, 2025 15:03
@Soupstraw Soupstraw force-pushed the jj/revert-non-disjoint-check branch 6 times, most recently from 8bfce0d to 2f12961 Compare May 13, 2025 11:27
@Soupstraw Soupstraw requested a review from lehins May 13, 2025 11:37
@Soupstraw Soupstraw force-pushed the jj/revert-non-disjoint-check branch 5 times, most recently from 136c851 to 387459d Compare May 14, 2025 14:30
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
Couple of minor suggestions, but nothing critical.

@Soupstraw Soupstraw force-pushed the jj/revert-non-disjoint-check branch 2 times, most recently from 758e5e1 to 622fd9c Compare May 15, 2025 16:03
… scripts

Add majorVersionAtLeast and majorVersionAtMost

Co-authored-by: Alexey Kuleshevich <[email protected]>
@Soupstraw Soupstraw force-pushed the jj/revert-non-disjoint-check branch from 622fd9c to 44de8ed Compare May 19, 2025 10:43
@Soupstraw Soupstraw merged commit 8a5b2e7 into master May 19, 2025
128 of 129 checks passed
@Soupstraw Soupstraw deleted the jj/revert-non-disjoint-check branch May 19, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants