Skip to content

Added Dijkstra era #5030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added Dijkstra era #5030

wants to merge 3 commits into from

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented May 8, 2025

Description

This PR sets up a subproject for the new Dijkstra era

close #4955

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Soupstraw Soupstraw force-pushed the jj/dijkstra-certs branch from cb80f34 to 688f2ba Compare May 8, 2025 12:52
@@ -38,6 +38,7 @@ packages:
eras/babbage/test-suite
eras/conway/impl
eras/conway/test-suite
eras/dijkstra
Copy link
Contributor Author

@Soupstraw Soupstraw May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to put the project directly into eras/dijkstra, since we don't want to have the cardano-ledger-<era>-test packages anymore. This gives us a shorter path to Dijkstra 😉

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is fine, especially since that is the ultimate goal for all of the previous eras. 👍

@Soupstraw Soupstraw marked this pull request as ready for review May 8, 2025 13:17
@Soupstraw Soupstraw requested a review from a team as a code owner May 8, 2025 13:17
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not what I had in mind when I created a ticket.

We need an era that is equivalent to Conway, not just a placeholder package.

In other words it should reuse all of the types and rules and should be running all of the reusable tests from previous eras, including impspec

@lehins
Copy link
Collaborator

lehins commented May 9, 2025

@Soupstraw While performing this task I would like for you to also write up a document that explains the steps that are necessary to follow in order to define a new blank era that matches the behavior of the previous one exactly and executes all of the same tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new era named Dijkstra
2 participants