Conversation
cb80f34 to
688f2ba
Compare
lehins
left a comment
There was a problem hiding this comment.
That is not what I had in mind when I created a ticket.
We need an era that is equivalent to Conway, not just a placeholder package.
In other words it should reuse all of the types and rules and should be running all of the reusable tests from previous eras, including impspec
|
@Soupstraw While performing this task I would like for you to also write up a document that explains the steps that are necessary to follow in order to define a new blank era that matches the behavior of the previous one exactly and executes all of the same tests. |
a1f79ae to
653e068
Compare
8ad56f1 to
e6687a0
Compare
0ad9a04 to
1b87737
Compare
ca870e4 to
93ed7dd
Compare
0a1be72 to
af584e4
Compare
af584e4 to
8a8f90a
Compare
9990534 to
ecb01a4
Compare
ecb01a4 to
58124ec
Compare
lehins
left a comment
There was a problem hiding this comment.
This looks awesome! Thank you for all the simplification and changes to tests reusability
eeb3f6a to
337f767
Compare
3d3f908 to
7463b4b
Compare
|
Looks like it is ready to go, just need to run formatters |
728d103 to
2d38499
Compare
Removed era parameter from GovActionId Made some Conway tests era-generic Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
2d38499 to
9d1af1d
Compare
|
Is it intentional that this PR still has ? Fixing this also requires adding a (probably trivial for now) Dijkstra.Transition module.
|
|
Good idea. I'll have a PR ready tomorrow.10:39 AM, June 2, 2025, amesgen ***@***.***>:amesgen left a comment (IntersectMBO/cardano-ledger#5030)
Is it intentional that this PR still has
https://github.com/IntersectMBO/cardano-ledger/blob/b3452e4e74e590d268d604778cbd6899ffbfb375/libs/cardano-ledger-api/src/Cardano/Ledger/Api/Era.hs#L80
? Fixing this also requires adding a (probably trivial for now) Dijkstra.Transition module.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
Отправлено из мобильной Яндекс.Почты: http://m.ya.ru/ymail
|
Description
This PR sets up a subproject for the new
DijkstraeraI removed unnecessary
eraparametrization fromGovActionIdto make translations easier.close #4955
close #5043
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).