-
Notifications
You must be signed in to change notification settings - Fork 156
Added Dijkstra era #5030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added Dijkstra era #5030
Conversation
cb80f34
to
688f2ba
Compare
@@ -38,6 +38,7 @@ packages: | |||
eras/babbage/test-suite | |||
eras/conway/impl | |||
eras/conway/test-suite | |||
eras/dijkstra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to put the project directly into eras/dijkstra
, since we don't want to have the cardano-ledger-<era>-test
packages anymore. This gives us a shorter path to Dijkstra 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is fine, especially since that is the ultimate goal for all of the previous eras. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not what I had in mind when I created a ticket.
We need an era that is equivalent to Conway, not just a placeholder package.
In other words it should reuse all of the types and rules and should be running all of the reusable tests from previous eras, including impspec
@Soupstraw While performing this task I would like for you to also write up a document that explains the steps that are necessary to follow in order to define a new blank era that matches the behavior of the previous one exactly and executes all of the same tests. |
Description
This PR sets up a subproject for the new
Dijkstra
eraclose #4955
Checklist
CHANGELOG.md
files updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabal
andCHANGELOG.md
files when necessary, according to theversioning process.
.cabal
files updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh
).scripts/cabal-format.sh
).scripts/gen-cddl.sh
)hie.yaml
updated (usescripts/gen-hie.sh
).