Remove *Field data types from Generic tests#5144
Merged
Conversation
Soupstraw
force-pushed
the
jj/remove-fields
branch
from
755a450 to
0bc8099
Compare
Soupstraw
force-pushed
the
jj/remove-fields
branch
15 times, most recently
from
12bb842 to
1254bde
Compare
lehins
reviewed
Jul 9, 2025
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
This is a very nice simplification!
There is a problem with building on newer ghc, but other than that I don't see a reason why we can't merge it.
Soupstraw
force-pushed
the
jj/remove-fields
branch
from
1254bde to
c513083
Compare
teodanciu
reviewed
Jul 10, 2025
Soupstraw
force-pushed
the
jj/remove-fields
branch
2 times, most recently
from
2c1755e to
b17b600
Compare
Soupstraw
force-pushed
the
jj/remove-fields
branch
from
b17b600 to
3c08318
Compare
lehins
approved these changes
Jul 10, 2025
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Nice simplification. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the
Generictests framework by replacing theFielddatatypes with lenses. I removed some dead code and got rid ofProofs in a couple of places by turning the functions into typeclass methods.Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).