Skip to content

constrained-generators: Improve haddocks#5155

Merged
MaximilianAlgehed merged 1 commit intomasterfrom
max/constrained-docs
Jul 15, 2025
Merged

constrained-generators: Improve haddocks#5155
MaximilianAlgehed merged 1 commit intomasterfrom
max/constrained-docs

Conversation

@MaximilianAlgehed
Copy link
Contributor

@MaximilianAlgehed MaximilianAlgehed commented Jul 7, 2025

Description

This is an attempt to get more reasonable (not entirely reasonable yet!) haddocks in place for constrained-generators. There will be some silly stuff like:

-- | This function foobarifies its inputs
foobarify :: inputs -> output

But the goal is to get 100% coverage of docs on the main library with mostly reasonable haddocks that can be improved over time.

closes #5143

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@MaximilianAlgehed MaximilianAlgehed force-pushed the max/constrained-docs branch 13 times, most recently from 9796faa to 527dd81 Compare July 14, 2025 11:59
@MaximilianAlgehed MaximilianAlgehed force-pushed the max/constrained-docs branch 10 times, most recently from 2d2471b to 4f48c3a Compare July 15, 2025 09:10
@MaximilianAlgehed MaximilianAlgehed marked this pull request as ready for review July 15, 2025 09:10
@MaximilianAlgehed MaximilianAlgehed requested a review from a team as a code owner July 15, 2025 09:10
@MaximilianAlgehed MaximilianAlgehed force-pushed the max/constrained-docs branch 4 times, most recently from e07b4c1 to a2f6d88 Compare July 15, 2025 11:22
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just a few small typo comments. When we make haddock files, where do they go? It would be nice to look at the haddock files to judge how they look and feel.

@MaximilianAlgehed
Copy link
Contributor Author

@TimSheard on my machine I get this output as the final lines from cabal haddock:

Documentation created:
/home/max/IOHK/cardano-ledger/dist-newstyle/build/x86_64-linux/ghc-9.12.2/constrained-generators-0.2.0.0/doc/html/constrained-generators

@MaximilianAlgehed MaximilianAlgehed enabled auto-merge (rebase) July 15, 2025 18:29
@MaximilianAlgehed
Copy link
Contributor Author

@TimSheard I'll take another pass over the documentation and fix all the warnings and improve it some more after we've merged this, but I'd like to get the new repo set up first so that we have that out of the way.

@MaximilianAlgehed MaximilianAlgehed merged commit 2f7b3dd into master Jul 15, 2025
132 checks passed
@MaximilianAlgehed MaximilianAlgehed deleted the max/constrained-docs branch July 15, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

constrained-generators: Haddocks

2 participants