constrained-generators: Improve haddocks#5155
Merged
MaximilianAlgehed merged 1 commit intomasterfrom Jul 15, 2025
Merged
Conversation
9796faa to
527dd81
Compare
2d2471b to
4f48c3a
Compare
e07b4c1 to
a2f6d88
Compare
a2f6d88 to
33ef0a2
Compare
TimSheard
approved these changes
Jul 15, 2025
Contributor
TimSheard
left a comment
There was a problem hiding this comment.
This looks good, just a few small typo comments. When we make haddock files, where do they go? It would be nice to look at the haddock files to judge how they look and feel.
33ef0a2 to
5a1e96d
Compare
Contributor
Author
|
@TimSheard on my machine I get this output as the final lines from |
Contributor
Author
|
@TimSheard I'll take another pass over the documentation and fix all the warnings and improve it some more after we've merged this, but I'd like to get the new repo set up first so that we have that out of the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an attempt to get more reasonable (not entirely reasonable yet!) haddocks in place for
constrained-generators. There will be some silly stuff like:But the goal is to get 100% coverage of docs on the main library with mostly reasonable haddocks that can be improved over time.
closes #5143
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).