Skip to content

Change the type of dRepDeposits to CompactForm Coin#5163

Merged
Soupstraw merged 2 commits intomasterfrom
jj/drepdeposits-compact-coin
Jul 23, 2025
Merged

Change the type of dRepDeposits to CompactForm Coin#5163
Soupstraw merged 2 commits intomasterfrom
jj/drepdeposits-compact-coin

Conversation

@Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Jul 11, 2025

Description

This PR changes the type of dRepDeposits from Coin to CompactForm, similar to what I did to poolDeposits in #5031.

close #5094

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Soupstraw Soupstraw force-pushed the jj/drepdeposits-compact-coin branch 4 times, most recently from 66c90bc to ecf48aa Compare July 15, 2025 11:15
@Soupstraw Soupstraw marked this pull request as ready for review July 15, 2025 11:18
@Soupstraw Soupstraw requested a review from a team as a code owner July 15, 2025 11:18
@Soupstraw Soupstraw force-pushed the jj/drepdeposits-compact-coin branch from ecf48aa to 7e91599 Compare July 15, 2025 11:21
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@lehins
Copy link
Collaborator

lehins commented Jul 15, 2025

CI is still failing

@Soupstraw Soupstraw force-pushed the jj/drepdeposits-compact-coin branch 3 times, most recently from e7b1280 to 87d0301 Compare July 17, 2025 13:00
@Soupstraw Soupstraw force-pushed the jj/drepdeposits-compact-coin branch from 87d0301 to 51cdd34 Compare July 23, 2025 11:35
@Soupstraw Soupstraw force-pushed the jj/drepdeposits-compact-coin branch from 51cdd34 to 2d48a93 Compare July 23, 2025 14:15
@Soupstraw Soupstraw enabled auto-merge (rebase) July 23, 2025 15:37
@Soupstraw Soupstraw merged commit a7fb33a into master Jul 23, 2025
125 of 130 checks passed
@Soupstraw Soupstraw deleted the jj/drepdeposits-compact-coin branch July 23, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch DRep deposit to use CompactCoin

2 participants