Skip to content

Refactor some parts of cardano-ledger-conformance to prepare for Dijkstra#5195

Merged
carlostome merged 4 commits intomasterfrom
carlos/refactor-conformance-dijkstra
Sep 12, 2025
Merged

Refactor some parts of cardano-ledger-conformance to prepare for Dijkstra#5195
carlostome merged 4 commits intomasterfrom
carlos/refactor-conformance-dijkstra

Conversation

@carlostome
Copy link
Contributor

@carlostome carlostome commented Jul 30, 2025

Description

This PR:

  • Renames the module SpecTransalate.Core to SpecTranslate.Base, so as to follow the naming structure of formal-ledger-specifications
  • Moves SpecTranslate instances
    • from Conway.Base to SpecTranslate.Base, those which are (loosely) Ledger-independent
    • from Conway.Base to SpecTranslate.Core, those which are era-independent
  • Removes a stale link to fls in CONTRIBUTING.md

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@carlostome carlostome marked this pull request as ready for review July 30, 2025 15:22
@carlostome carlostome requested a review from a team as a code owner July 30, 2025 15:22
@carlostome carlostome requested a review from Soupstraw July 30, 2025 15:30
@carlostome carlostome force-pushed the carlos/refactor-conformance-dijkstra branch from a7b2049 to 59bb5ee Compare July 30, 2025 15:30
@Soupstraw
Copy link
Contributor

This PR is going to cause a lot of conflicts with #5187

Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to reimplement this PR once I have merged the big conformance refactoring PR.

@carlostome carlostome force-pushed the carlos/refactor-conformance-dijkstra branch 2 times, most recently from 7e988fc to c1d9790 Compare August 19, 2025 08:20
@carlostome carlostome requested a review from Soupstraw August 19, 2025 08:22
@carlostome carlostome force-pushed the carlos/refactor-conformance-dijkstra branch 3 times, most recently from 3b8014d to 903bf97 Compare August 22, 2025 14:49
@carlostome carlostome moved this to In Progress in Dijkstra formal spec Aug 22, 2025
@carlostome carlostome force-pushed the carlos/refactor-conformance-dijkstra branch 2 times, most recently from 27dea56 to 51ff3da Compare August 26, 2025 14:24
@carlostome carlostome force-pushed the carlos/refactor-conformance-dijkstra branch from 51ff3da to 799b0da Compare September 1, 2025 14:39
@aniketd aniketd force-pushed the carlos/refactor-conformance-dijkstra branch from 799b0da to 0448984 Compare September 5, 2025 08:25
@carlostome carlostome force-pushed the carlos/refactor-conformance-dijkstra branch 2 times, most recently from d98b2e8 to fbc5ef8 Compare September 8, 2025 14:30
@carlostome carlostome requested a review from Soupstraw September 8, 2025 16:06
@carlostome carlostome force-pushed the carlos/refactor-conformance-dijkstra branch from 0f139e4 to 712707c Compare September 10, 2025 09:28
@carlostome carlostome force-pushed the carlos/refactor-conformance-dijkstra branch from 712707c to 96e1992 Compare September 12, 2025 06:31
@carlostome carlostome force-pushed the carlos/refactor-conformance-dijkstra branch from 96e1992 to 3d7bc8f Compare September 12, 2025 06:34
@carlostome carlostome merged commit cf7b1d7 into master Sep 12, 2025
235 of 237 checks passed
@carlostome carlostome deleted the carlos/refactor-conformance-dijkstra branch September 12, 2025 10:15
@github-project-automation github-project-automation bot moved this from In Progress to Done in Dijkstra formal spec Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants