Skip to content

Made predicate failures for TICK subrules Void in Shelley#5259

Merged
Soupstraw merged 1 commit intomasterfrom
jj/remove-shelley-predfailure
Sep 1, 2025
Merged

Made predicate failures for TICK subrules Void in Shelley#5259
Soupstraw merged 1 commit intomasterfrom
jj/remove-shelley-predfailure

Conversation

@Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Aug 28, 2025

Description

This PR removes predicate failure types from all the subrules of TICK, since we can't have any predicate failures when crossing the epoch.

close #4158

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Soupstraw Soupstraw changed the title Made predicate failures for NEWEPOCH subrules Void in Shelley Made predicate failures for TICK subrules Void in Shelley Aug 28, 2025
@Soupstraw Soupstraw changed the title Made predicate failures for TICK subrules Void in Shelley Made predicate failures for TICK subrules Void in Shelley Aug 28, 2025
@Soupstraw Soupstraw force-pushed the jj/remove-shelley-predfailure branch from 59cc73a to 0da0e35 Compare August 28, 2025 13:49
@Soupstraw Soupstraw marked this pull request as ready for review August 28, 2025 13:50
@Soupstraw Soupstraw requested a review from a team as a code owner August 28, 2025 13:50
@Soupstraw Soupstraw force-pushed the jj/remove-shelley-predfailure branch from 0da0e35 to 6db1056 Compare August 28, 2025 13:51
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you!

@Soupstraw Soupstraw force-pushed the jj/remove-shelley-predfailure branch from 6db1056 to 17f4d10 Compare September 1, 2025 09:22
@Soupstraw Soupstraw enabled auto-merge (rebase) September 1, 2025 09:52
@Soupstraw Soupstraw force-pushed the jj/remove-shelley-predfailure branch from 17f4d10 to 2f7b6ee Compare September 1, 2025 12:23
@Soupstraw Soupstraw merged commit a507f92 into master Sep 1, 2025
118 of 121 checks passed
@Soupstraw Soupstraw deleted the jj/remove-shelley-predfailure branch September 1, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove all predicate failures for descendants of TICK rule

2 participants