Skip to content

Fix wrong use of mempty deposit in pool registration test#5261

Merged
aniketd merged 1 commit intomasterfrom
aniketd/nightly-ci
Aug 29, 2025
Merged

Fix wrong use of mempty deposit in pool registration test#5261
aniketd merged 1 commit intomasterfrom
aniketd/nightly-ci

Conversation

@aniketd
Copy link
Contributor

@aniketd aniketd commented Aug 28, 2025

Description

Test failures seen on Nightly CI:

There was a stray but suspicious mempty used to compare PoolParams with an expected StakePoolState, since we do not have access to the protocol parameters in that scope. Switching to comparing just PoolParams with PoolParams makes this test actually correct.

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@aniketd aniketd requested a review from neilmayhew August 28, 2025 15:10
@aniketd aniketd marked this pull request as ready for review August 28, 2025 15:10
@aniketd aniketd requested a review from a team as a code owner August 28, 2025 15:10
@aniketd aniketd force-pushed the aniketd/nightly-ci branch from 372905f to 48cc6d8 Compare August 28, 2025 15:10
@aniketd aniketd enabled auto-merge August 29, 2025 10:19
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you.

@aniketd aniketd merged commit 184986d into master Aug 29, 2025
121 checks passed
@aniketd aniketd deleted the aniketd/nightly-ci branch August 29, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants