Conversation
teodanciu
force-pushed
the
td/vrfs-counters
branch
5 times, most recently
from
a04a7e6 to
bb61dee
Compare
in order to avoid pools retiring after the HardFork from removing the record of a known (but duplicate) VRF key hash
teodanciu
force-pushed
the
td/vrfs-counters
branch
from
bb61dee to
016a937
Compare
teodanciu
changed the title
teodanciu
commented
Sep 2, 2025
teodanciu
commented
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If stake pools with the same VRF key hash exist, then - in the current version - at HardFork we lose the information that it occurs several times, by collapsing all occurrences in a Set.
So, if after the HardFork, one of these pools retires, we remove the VRF key from the record, even though there might be other stake pools left with this key. This allows for the VRF key to be used again!
This PR solves this problem, by removing individual occurrences of VRF key hashes.
Fixes #5252
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).