Re-implement TxInfoSpec as an ImpTest#5278
Merged
Conversation
Soupstraw
force-pushed
the
jj/alonzo-txinfo-imptest
branch
2 times, most recently
from
1110760 to
7eeee34
Compare
Soupstraw
force-pushed
the
jj/alonzo-txinfo-imptest
branch
4 times, most recently
from
dde3349 to
ca3a868
Compare
aniketd
reviewed
Sep 10, 2025
Contributor
aniketd
left a comment
aniketd
left a comment
There was a problem hiding this comment.
So much better! 🙌 Awesome!
lehins
requested changes
Sep 12, 2025
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
It's a very nice improvement.
There are a few more simplifications we can make by utilizing ImpSpec to its fullest potential
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Imp/TxInfoSpec.hs
Outdated
Show resolved
Hide resolved
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Imp/TxInfoSpec.hs
Outdated
Show resolved
Hide resolved
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Imp/TxInfoSpec.hs
Outdated
Show resolved
Hide resolved
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Imp/TxInfoSpec.hs
Outdated
Show resolved
Hide resolved
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Imp/TxInfoSpec.hs
Outdated
Show resolved
Hide resolved
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Imp/TxInfoSpec.hs
Outdated
Show resolved
Hide resolved
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Imp/TxInfoSpec.hs
Outdated
Show resolved
Hide resolved
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Imp/TxInfoSpec.hs
Outdated
Show resolved
Hide resolved
teodanciu
force-pushed
the
jj/alonzo-txinfo-imptest
branch
from
ca3a868 to
49767c3
Compare
Contributor
|
Alexey asked if someone wanted to look after this in your absence, @Soupstraw . |
teodanciu
force-pushed
the
jj/alonzo-txinfo-imptest
branch
from
49767c3 to
be930d6
Compare
teodanciu
force-pushed
the
jj/alonzo-txinfo-imptest
branch
from
be930d6 to
375592f
Compare
lehins
force-pushed
the
jj/alonzo-txinfo-imptest
branch
from
375592f to
c5c81b4
Compare
teodanciu
force-pushed
the
jj/alonzo-txinfo-imptest
branch
from
c5c81b4 to
72508a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
TxInfoSpectests asImpTests.close #5210
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).