Added FromJSON instance for PParamUpdates#5281
Merged
Conversation
Soupstraw
force-pushed
the
jj/ppupdate-json
branch
3 times, most recently
from
ee15bb5 to
a9acf52
Compare
teodanciu
reviewed
Sep 9, 2025
Contributor
teodanciu
left a comment
teodanciu
left a comment
There was a problem hiding this comment.
The implementation looks correct to me, but I wonder if my suggestion could prevent the new helper type.
And, if that's not the case, it doesn't seem like we should exporting it.
Soupstraw
force-pushed
the
jj/ppupdate-json
branch
6 times, most recently
from
b431d8e to
fbff13e
Compare
teodanciu
approved these changes
Sep 11, 2025
Contributor
teodanciu
left a comment
teodanciu
left a comment
There was a problem hiding this comment.
Looks good to me
This allows us to make the golden tests better, so that the golden files don't get spontaneously regenerated (since they're created with quickcheck).
Contributor
Soupstraw
force-pushed
the
jj/ppupdate-json
branch
from
fbff13e to
c7b644a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
FromJSONinstance toPParamsUpdate.close #5052
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).