Move withdrawals to LEDGER PV 11 onwards#5291
Merged
Conversation
aniketd
force-pushed
the
aniketd/move-withdrawals-to-ledger-rule
branch
from
4bf0b14 to
409120b
Compare
10 tasks
aniketd
commented
Sep 15, 2025
Contributor
Author
aniketd
left a comment
aniketd
left a comment
There was a problem hiding this comment.
This makes reading better since it puts the noop upfront.
aniketd
force-pushed
the
aniketd/move-withdrawals-to-ledger-rule
branch
2 times, most recently
from
7b87503 to
6efdee7
Compare
aniketd
commented
Sep 16, 2025
aniketd
force-pushed
the
aniketd/move-withdrawals-to-ledger-rule
branch
2 times, most recently
from
bfbf41d to
33bfe8d
Compare
aniketd
commented
Sep 16, 2025
aniketd
force-pushed
the
aniketd/move-withdrawals-to-ledger-rule
branch
from
33bfe8d to
1c49e7c
Compare
lehins
requested changes
Sep 16, 2025
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
A little bit of duplication in order to get clearer and more readable code is very much worth it. So, please revert this whole updateDRepExpiriesAndDrainWithdrawals abstraction and just inline the functionality like you had it before
lehins
reviewed
Sep 16, 2025
aniketd
force-pushed
the
aniketd/move-withdrawals-to-ledger-rule
branch
from
1c49e7c to
de85ba6
Compare
teodanciu
reviewed
Sep 17, 2025
Contributor
teodanciu
left a comment
teodanciu
left a comment
There was a problem hiding this comment.
A few comments, mostly about CHANGELOG.
It's nice that we split into updateDormantDRepExpiries and updateVotingDRepExpiries - it helps with understanding what's going on in the rule!
lehins
reviewed
Sep 17, 2025
aniketd
force-pushed
the
aniketd/move-withdrawals-to-ledger-rule
branch
2 times, most recently
from
1962745 to
b8e0d56
Compare
aniketd
force-pushed
the
aniketd/move-withdrawals-to-ledger-rule
branch
from
b8e0d56 to
42451bf
Compare
...from CERTS, protocol version 11 onwards. ...because LEDGER is a more suitable place for these operations. They run just before the CERTS rule transition in LEDGER. Also have two predicate failures in LEDGER instead of only one in CERTS, to report the specific cases of missing accounts/wrong network vs. incomplete withdrawal-amounts. Update changelogs. Bump versions for conway and core.
aniketd
force-pushed
the
aniketd/move-withdrawals-to-ledger-rule
branch
from
42451bf to
da7a38f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Potentially refactor the common part out to be reused in both CERTS and LEDGER.Supersedes #5279
Closes #4640 and #4932
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).