Add a golden test for duplicate certificates #5370
Open
+67
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/fail-on-duplicate-certs
branch
3 times, most recently
from
70bd106 to
4f1eb3f
Compare
Soupstraw
force-pushed
the
jj/fail-on-duplicate-certs
branch
2 times, most recently
from
1bf8e74 to
da08be6
Compare
Soupstraw
force-pushed
the
jj/fail-on-duplicate-certs
branch
from
da08be6 to
218e543
Compare
lehins
approved these changes
Nov 3, 2025
| (DeserialiseFailure 0 "List encoding of redeemers not supported starting with PV 12") | ||
| ) | ||
|
|
||
| duplicateCertsTx :: forall era. DijkstraEraTest era => Version -> Enc |
There was a problem hiding this comment.
I think it would be an awesome addition if we moved this example to shelley era and added it as a positive test, where:
- In Shelley till Babbage we successfully decode such transaction, but only one certificate is preserved
- In Conway only one certificate is preserved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close #4566 once this test is passing
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).