Skip to content

Introduce pots/v0 namespace for canonical state#5552

Open
qnikst wants to merge 1 commit intomasterfrom
qnikst/canonical-pots-v0
Open

Introduce pots/v0 namespace for canonical state#5552
qnikst wants to merge 1 commit intomasterfrom
qnikst/canonical-pots-v0

Conversation

@qnikst
Copy link
Collaborator

@qnikst qnikst commented Jan 29, 2026

Description

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@qnikst qnikst requested a review from a team as a code owner January 29, 2026 19:28
@qnikst
Copy link
Collaborator Author

qnikst commented Jan 29, 2026

This PR is based on top of the #5548 and is intended to be merged and reviewed after that one

@qnikst qnikst force-pushed the qnikst/canonical-pots-v0 branch 2 times, most recently from d3f1926 to 2935352 Compare February 1, 2026 23:20
New namespace, that follows the same patterns as utxo and blocks
namespace.
@qnikst qnikst force-pushed the qnikst/canonical-pots-v0 branch from 2935352 to e8a773b Compare February 3, 2026 15:03
@qnikst qnikst requested a review from lehins February 3, 2026 15:04
@qnikst
Copy link
Collaborator Author

qnikst commented Feb 3, 2026

I've prepared a commit for the next namespace, interesting and discussible thing here is introducing CanonicalCoin and type class for conversion. This is related to the conversation about integer conversion happened on the meeting 2026-02-02, whether a library should be used to make it safe. Theoretically it's unsafe to convert from CanonicalCoin Integer to CompactCoin that is 64bit size.

I could adopt the code to the approach chosen by the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant